feat: use exec when calling java from script #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Spring Boot parent version and improves process management in startup scripts by replacing direct command execution with exec.
- Spring Boot parent version upgraded from 3.5.4 to 3.5.7
- Added
execprefix to Java process invocations in all startup scripts for proper signal handling
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates Spring Boot parent version from 3.5.4 to 3.5.7 |
| src/main/rpm/start.sh | Adds exec prefix to Java command for proper process replacement |
| src/main/deb/systemd/start.sh | Adds exec prefix to Java command for proper process replacement |
| src/main/bin/rock | Adds exec prefix to Java command for proper process replacement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.