-
Notifications
You must be signed in to change notification settings - Fork 147
Fix examples for JDK 21 (Android Studio Ladybug) #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples for JDK 21 (Android Studio Ladybug) #695
Conversation
2dd62a3 to
ecb998c
Compare
|
Would this PR make the warnings below that objectbox currently give me disappear? |
|
@hagerf No, it won't. Thanks for reporting! This warning occurs due to using JDK 21 to compile. But we can make changes to the Flutter plugins to suppress it, made an internal note about that ( If it bothers you, you can try to suppress the warning yourself. You likely need to add something like below to the relevant Gradle script in the Long term we need to use the Java 11 level to compile (Flutter appears to also prepare for that), but that has other complications (like a higher minimum supported Android SDK level). |
|
Thanks for the quick and detailed answer! |
|
As part of this change I plan to suppress the warnings. And no, there is currently only an internal task to update to Java 11 level once it makes sense. |
|
Is this planned to be released soon? And maybe we could add this to this as well? I'm experiencing issues with updating some dependencies because object box is using old source_gen versions. |
|
@hagerf Please avoid asking for updates, we will provide them when we have them. Reading and answering comments like this take time away from actually working on tasks. |
aba06d2 to
3a2f021
Compare
7b065d6 to
bb912e4
Compare
At least Flutter SDK 3.7.12: This matches what can be built by CI due to dependency constraints, so is the lowest version users could possibly be using. At least Flutter SDK 3.13.9: required to upgrade to Android Gradle Plugin 8.2.1 (to support JDK 21) which requires using the namespace property. At least Flutter SDK 3.16.9: required to apply Flutter plugin using plugins block, which is required to do further changes to support JDK 21.
Also improve help output if run without arguments.
Tested Flutter version is higher than 3.19.0 now, so no need to override any longer.
bb912e4 to
7fdd176
Compare
7fdd176 to
69dc5eb
Compare
Public PR to run GitHub Actions.