fix: show test connection button for custom S3 storage provider #5028
+13
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryu-man
requested review from
StrongMonkey,
g-linville,
ivyjeong13 and
njhale
ivyjeong13
approved these changes
Nov 17, 2025
Contributor
ivyjeong13
left a comment
ivyjeong13
left a comment
There was a problem hiding this comment.
Didn't pull this down but assuming the case of why the if was originally there was already addressed separately?
Contributor
|
@ryu-man We don't have test connection backend functionlities for custom s3, so we are intentionally hiding it. |
Contributor
Author
|
@StrongMonkey I see. I'm going to close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4917