fix: configure multi-user component tools without acr and component search #5050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents servers in PU and PUP from appearing in the component server search dialog for constructing composite MCP catalog entries. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
Add an authz rule that grants admins access to list tools for all MCP servers using the `/api/all-mcps/servers/<mcpserver_id>/tools` endpoint. This endpoint is currently used in the admin UI to display tools for multi-user servers and fails if there's no ACR granting the admin access to the server. When this happens: - The `Tools` tab for a multi-user server would show the `Populate Tool Preview` button (which would also fail when clicked b/c it's not a catalog entry) - Tool overrides can't be generated for these multi-user MCP servers Addresses obot-platform#5034 Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
requested review from
StrongMonkey,
g-linville,
ivyjeong13 and
thedadams
njhale
changed the title
thedadams
approved these changes
Nov 17, 2025
g-linville
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent servers in PU and PUP from appearing in the component server search dialog for constructing composite MCP catalog entries
Add an authz rule that grants admins access to list tools for all MCP servers using the
/api/all-mcps/servers/<mcpserver_id>/toolsendpoint.This endpoint is currently used in the admin UI to display tools for multi-user servers
and fails if there's no ACR granting the admin access to the server.
When this happens:
Toolstab for a multi-user server would show thePopulate Tool Previewbutton(which would also fail when clicked b/c it's not a catalog entry)
Addresses #5034