Open
Conversation
…m/adaptive_scheduler into add_orchestrator
…cheduler into document_orchestrator
…rator Document orchestrator
…cheduler into add_orchestrator
…rolsystem/adaptive_scheduler into add_orchestrator
…_in_orchestrator Optimize airmass in orchestrator
jnation3406
commented
Aug 10, 2022
|
|
||
| # assumption: if it's trying to read the licence, it's probably linked properly | ||
| strace -e openat python -c "from ortools.linear_solver import pywraplp as p; p.Solver.CreateSolver('GUROBI')" 2>&1 | grep -q gurobi.lic | ||
| # strace -e openat python -c "from ortools.linear_solver import pywraplp as p; p.Solver.CreateSolver('GUROBI')" 2>&1 | grep -q gurobi.lic |
Member
Author
There was a problem hiding this comment.
This is just so the interns could build the container without full priviledges - we can remove this comment
jnation3406
commented
Aug 10, 2022
|
|
||
| def __init__(self, configdb_url, telescope_classes, telescopes_file='data/telescopes.json', | ||
| active_instruments_file='data/active_instruments.json'): | ||
| active_instruments_file='data/active_instruments.json', overrides=None): |
Member
Author
There was a problem hiding this comment.
The changes in this file all pertain to being able to override configdb values with a dict provided (which can be read in from a simple json file in the simulation orchestrator)
…m/adaptive_scheduler into add_orchestrator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the full set of changes from the interns. This branch has already pulled in the feature/optimize_airmass branch, which is why I have it diff-ing off that branch rather than main. When reviewing, focus on the simulate package and specifically the metrics/plots files.