Skip to content

feat: Workspace 1074#176

Open
SKairinos wants to merge 104 commits intomainfrom
workspace_1074_2
Open

feat: Workspace 1074#176
SKairinos wants to merge 104 commits intomainfrom
workspace_1074_2

Conversation

@SKairinos
Copy link
Copy Markdown
Contributor

@SKairinos SKairinos commented Mar 9, 2026

This change is Reviewable

@SKairinos SKairinos linked an issue Mar 9, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faucomte97 reviewed 79 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on SKairinos).


Pipfile line 25 at r1 (raw file):

gunicorn = "==23.0.0"
uvicorn-worker = "==0.2.0"
pyjwt = "==2.12.1" 

Trailing whitespace


codeforlife/user/models/school.py line 49 at r1 (raw file):

    field_aliases = {
        "name": {"_name_plain", "_name_enc"},
        "county": {"_county_plain", "_county_enc"},

Wondering if we should not encrypt the county. Mainly because it would cause issues in BQ / Looker.
And it's not an open text field, and doesn't constitute direct PII.

Copy link
Copy Markdown
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SKairinos made 2 comments.
Reviewable status: 70 of 79 files reviewed, 2 unresolved discussions (waiting on faucomte97).


Pipfile line 25 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Trailing whitespace

Done.


codeforlife/user/models/school.py line 49 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Wondering if we should not encrypt the county. Mainly because it would cause issues in BQ / Looker.
And it's not an open text field, and doesn't constitute direct PII.

Done. I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle existing data

2 participants