Conversation
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 reviewed 79 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on SKairinos).
Pipfile line 25 at r1 (raw file):
gunicorn = "==23.0.0" uvicorn-worker = "==0.2.0" pyjwt = "==2.12.1"
Trailing whitespace
codeforlife/user/models/school.py line 49 at r1 (raw file):
field_aliases = { "name": {"_name_plain", "_name_enc"}, "county": {"_county_plain", "_county_enc"},
Wondering if we should not encrypt the county. Mainly because it would cause issues in BQ / Looker.
And it's not an open text field, and doesn't constitute direct PII.
SKairinos
left a comment
There was a problem hiding this comment.
@SKairinos made 2 comments.
Reviewable status: 70 of 79 files reviewed, 2 unresolved discussions (waiting on faucomte97).
Pipfile line 25 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Trailing whitespace
Done.
codeforlife/user/models/school.py line 49 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Wondering if we should not encrypt the county. Mainly because it would cause issues in BQ / Looker.
And it's not an open text field, and doesn't constitute direct PII.
Done. I agree
This change is