chore: add dir field to dune-project #12647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-vzzvqnstwxzp
branch
8 times, most recently
from
e64e35e to
ba38bc5
Compare
rgrinberg
approved these changes
Oct 30, 2025
rgrinberg
requested changes
Oct 30, 2025
| @@ -1,4 +1,3 @@ | |||
| (test | |||
| (name artifact_substitution) | |||
| (package dune-private-libs) | |||
Member
There was a problem hiding this comment.
These tests need to be moved to their correct places, otherwise the race conditions will be back.
Collaborator
Author
There was a problem hiding this comment.
Artifact substitution doesn't appear to have anything to do with dune-private-libs however.
Alizter
force-pushed
the
push-vzzvqnstwxzp
branch
from
ba38bc5 to
9d25ad5
Compare
Alizter
commented
Nov 10, 2025
| @@ -1,5 +1,4 @@ | |||
| (test | |||
| (name gh637) | |||
| (package dune-private-libs) | |||
Collaborator
Author
There was a problem hiding this comment.
This also appears to use only stdune and src/ocaml_config.
Alizter
force-pushed
the
push-vzzvqnstwxzp
branch
from
9d25ad5 to
e36e975
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-vzzvqnstwxzp
branch
from
e36e975 to
50ad67a
Compare
rgrinberg
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add
dirfields to most packages indune-project. For this to work, we stop building the vendored version ofppandcsexpin the main build and leave it only for the bootstrap as we have done for other vendored packages.This should lessen the impact of the various race conditions we keep getting in the opam CI.