Skip to content

Conversation

@Alizter
Copy link
Collaborator

@Alizter Alizter commented Dec 28, 2025

Previously when a user tried to run a disabled cram test, set using the (enabled_if) field of the (cram) stanza, they would see dune succeed silently having skipped the test.

When this is part of dune runtest foo/ in a directory, this behaviour is fine. But if the user explicitly requested a disabled test then this behaviour can be confusing.

This PR introduces an error message when a user requests a disabled cram test, either via dune runtest or the test alias directly.

  • changelog
  • docs

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter marked this pull request as ready for review December 28, 2025 22:28
@Alizter Alizter requested a review from rgrinberg December 28, 2025 22:28
@rgrinberg
Copy link
Member

I don't think we want this behavior. Running a disabled explicitly should succeed.

@Alizter

This comment was marked as resolved.

@Alizter
Copy link
Collaborator Author

Alizter commented Dec 28, 2025

Hmm actually nevermind. I got confused about the enabled_if semantics here. I'll rethink this.

@Alizter Alizter marked this pull request as draft December 28, 2025 22:40
@rgrinberg
Copy link
Member

I think that we all we need is for enabled_if to control whether the test is added to the runtest (or w/e it is set to) alias. That will give us the right behavior everywhere else as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants