Skip to content

Conversation

@hannesm
Copy link
Member

@hannesm hannesm commented Oct 24, 2025

these fail in the lower bounds due to newer C compilers:

# + cc -c -I/usr/local/include test.c
# test.c: In function 'test':
# test.c:7:9: error: implicit declaration of function '__gmp_init'; did you mean '__gmpf_init'? [-Wimplicit-function-declaration]
#     7 |         __gmp_init();
#       |         ^~~~~~~~~~
#       |         __gmpf_init

@jmid
Copy link
Member

jmid commented Oct 24, 2025

Yes, please! Should the old versions be conserved by a corresponding PR to the archive repo to preserve balance in the universe? 🤔 (genuine question - I think the case can be made for both preservation and dropping)

@hannesm
Copy link
Member Author

hannesm commented Oct 24, 2025

@jmid we can preserve them of course if that is requested by someone.

@mseri
Copy link
Member

mseri commented Oct 27, 2025

For consistency's sake, I'd be in favour moving them to the archive in parallel with this PR. @shonfeder and @raphael-proust what do you think?

@raphael-proust
Copy link
Contributor

Also in favour of moving them to the archive. The alternative is to mark them as "avoid version". Either of those is fine with me.

@jmid
Copy link
Member

jmid commented Oct 28, 2025

Also in favour of moving them to the archive. The alternative is to mark them as "avoid version". Either of those is fine with me.

Already tried in #28540 and #28545 - yet the lower bounds check still tries them.

@jmid jmid mentioned this pull request Oct 30, 2025
@mseri mseri merged commit 263b2e6 into ocaml:master Oct 30, 2025
4 checks passed
@mseri
Copy link
Member

mseri commented Oct 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants