Skip to content

Bugfix:Fixed obproxyd.sh script terminator error and description error #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyberLife-Markus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix:Fixed obproxyd.sh script terminator error and description error #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfac53
bugfix:Fixed an issue with terminator errors causing scripts to not run
CyberLife-Markus Sep 26, 2022
43ca7a2
bugfix:Fixed a problem with incorrect caption description
CyberLife-Markus Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/deploy/obproxyd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ function check_opt()
else
echo "obproxy config server url:$OBPROXY_CONFIG_SERVER_URL"
OBPROXY_CONFIG_SERVER_URL_ARG=" -u $OBPROXY_CONFIG_SERVER_URL"
if
fi

# check PORT
if [ -z $OBPROXY_PORT ]
Expand Down
2 changes: 1 addition & 1 deletion src/obproxy/ob_proxy_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ void ObProxyMain::print_usage() const
MPRINT(" -R,--releaseid RELEASEID current obproxy kernel release id");
MPRINT(" -t,--regression_test TEST_NAME regression test");
MPRINT("example:");
MPRINT(" run without config server:");
MPRINT(" run without root service list:");
Copy link
Contributor

@lemon0910 lemon0910 Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config server指的是OCP提供的服务，用OCP service应该更好理解

Copy link
Author

@CyberLife-Markus CyberLife-Markus Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是描述写错了，下边151行还有一处run with config server

Copy link
Author

@CyberLife-Markus CyberLife-Markus Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/oceanbase/oceanbase/tree/master/tools/ob-configserver 从这个仓库来看是可自建config server的，下方调整为OCP service感觉有些局限

MPRINT(" ./bin/obproxy -p6789 -r'ip:port;ip:port' -n test -o enable_cluster_checkout=false,syslog_level=INFO");
MPRINT(" OR ./bin/obproxy -p6789 -r'ip:port;ip:port' -c 'ob_test' -n test -o syslog_level=INFO \n");
MPRINT(" run with config server:");
Expand Down