[IMP] account: add a search field to search for journal items by debit/credit #4845
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
There was a problem hiding this comment.
Commit message it wrongly formatted 👀 You can follow this guideline:
https://www.odoo.com/documentation/17.0/contributing/development/git_guidelines.html#commit-message-structure
| <field name="name"/> | ||
| <field name="ref"/> | ||
| <field name="invoice_date"/> | ||
| <field name="balance"/> |
There was a problem hiding this comment.
While this works well, another solution might be to use the debit and credit, why ? It will allow the user to type a positive number and have also all the negative since debit and credit are always positive 😄
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-t1-yagho
branch
from
c745284 to
1eb4115
Compare
yagho-odoo
changed the title
There was a problem hiding this comment.
Commit message is still empty, don't forget to add a small description of the change being made and the task-id like said in the guideline here
https://www.odoo.com/documentation/17.0/contributing/development/git_guidelines.html#commit-message-structure
| <field name="name" string="Journal Item" filter_domain="[ | ||
| '|', '|', '|', | ||
| ('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/> | ||
| <field name="name"/> |
There was a problem hiding this comment.
Indent here is not necessary ? Keep it like it was 😄
| <field name="ref"/> | ||
| <field name="invoice_date"/> | ||
| <field name="debit" string="Debit/Credit" filter_domain="[ | ||
| '|',('debit', '=', self), ('credit', '=', self)]" |
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-t1-yagho
branch
from
1eb4115 to
384188e
Compare
…t/credit when typing a number in the search, a new field depending on either the debit or credit can now be used to filter journal items, this is better than using just the balance field because the balance can be negative while debit or credit are always positive values task id: 5231294
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-t1-yagho
branch
from
384188e to
c85e8bb
Compare
yagho-odoo
changed the title
No description provided.