[IMP] account: added quick search on amount in journal items #4847
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
There was a problem hiding this comment.
Commit message title is good but there is no description of the change you did, for bigger pr it will be impossible to understand what is being done, so always add a description of the change 😄
you can follow that guideline:
https://www.odoo.com/documentation/17.0/contributing/development/git_guidelines.html#commit-message-structure
| <field name="tax_line_id" string="Originator Tax"/> | ||
| <field name="reconcile_model_id"/> | ||
| <field name="amount_currency" string="Amount" filter_domain="[ | ||
| ('amount_currency', '=', self)]"/> |
There was a problem hiding this comment.
ou used the amount_currency but i don't think that really what we want 👀 The amount currency will be the same as the balance or debit and credit when we have the same currency but it could happen that you do a transaction in dollars when your company is in euro and so the amount_currency will be different. Here we want to be able to search on the balance or debit and credit together 😄
also amount currency could be negative then your code will not work 👀
Wajih-Wanis
force-pushed
the
18.0-rd-accounting-onboarding-quick-search-waoun
branch
from
1450fc6 to
909ccda
Compare
[IMP] account: added the seach filter for the journal amount
Previously users can not search the journal items based on the amount thus motivated this changed to enable the user to search for the journal items by amount of balance.
task: Quick search on an amount in the journal items