[IMP] account: hide the invoice due date if the invoice is cancelled in list view #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 5, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Commit message need to be changed to fit the guideline and one small change that could be done 😄
| <field name="invoice_date" optional="show" column_invisible="context.get('default_move_type') not in ('out_invoice', 'out_refund', 'out_receipt')" readonly="state != 'draft'" string="Invoice Date" decoration-warning="abnormal_date_warning"/> | ||
| <field name="date" optional="hide" string="Accounting Date" readonly="state in ['cancel', 'posted']"/> | ||
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed')"/> | ||
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed') or status_in_payment == 'cancel'"/> |
There was a problem hiding this comment.
Instead of using status_in_payment that depends on the state, you can use state directly 😄
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-t2-yagho
branch
from
37e179c to
622cab3
Compare
yagho-odoo
changed the title
yagho-odoo
changed the title
malb-odoo
reviewed
Nov 5, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Commit message don't follow the guidelines 👀 and care you have a typo in the title ahah
…in list view for cancelled invoices, the due date was still showing even though it is not relevant anymore as no payment is expected task id: 5231295
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-t2-yagho
branch
from
622cab3 to
80918e0
Compare
yagho-odoo
changed the title
|
Same for the task, do task-..... otherwise you could have the case that have here where the number is actually link to something ahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for cancelled invoices, the due date was still showing even though it is not relevant anymore as no payment is expected