Skip to content

Conversation

@Wajih-Wanis
Copy link

@Wajih-Wanis Wajih-Wanis commented Nov 4, 2025

[IMP] account: changed BATCH to PAY

the previous value 'BATCH' on the group payment was confusing as it might seem to be related to the batch payment feature while it's not, thus the change to PAY as it would be more significant to the action being performed.

task : Group Payment: Change memo to PAY/XXXX

@robodoo
Copy link

robodoo commented Nov 4, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the commit message to follow the guideline and also check the tests 😄

'use_date_range': True,
'company_id': self.id,
'prefix': 'BATCH/%(year)s/',
'prefix': 'PAY/%(year)s/',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good but i think that if runbot was working like a normal pr, you would have a lot of test failing 👀 Take a look at addons/account/tests/test_account_payment_register.py 😄 Run the tests and check the ones that fails and fix them 😄

@Wajih-Wanis Wajih-Wanis force-pushed the 18.0-rd-accounting-grp-payment-waoun branch from f54cb9e to f73aa5f Compare November 6, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants