[IMP] account: add more visibility about the sent status of invoices #4861
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 5, 2025
| tracking=True, | ||
| help="It indicates that the invoice/payment has been sent or the PDF has been generated.", | ||
| ) | ||
| is_move_sent_string = fields.Selection( |
There was a problem hiding this comment.
In python it's kind of a bad practice to name a field with his type, why ? Because the type can change at any time during the execution. So maybe we could name the field move_sent_values
Comment on lines
618
to
624
| selection=[ | ||
| ("sent", "Sent"), | ||
| ("not_sent", "Not Sent") | ||
| ], | ||
| copy=False, | ||
| compute="_compute_is_move_sent_string" | ||
| ) |
There was a problem hiding this comment.
Rule of thumb when working with quotes in python --> Double quote for what the user will see, and single quote for other cases 😄
Suggested change
| selection=[ | |
| ("sent", "Sent"), | |
| ("not_sent", "Not Sent") | |
| ], | |
| copy=False, | |
| compute="_compute_is_move_sent_string" | |
| ) | |
| selection=[ | |
| ('sent', "Sent"), | |
| ('not_sent', "Not Sent") | |
| ], | |
| copy=False, | |
| compute='_compute_is_move_sent_string' | |
| ) |
Comment on lines
854
to
857
| if move.is_move_sent: | ||
| move.is_move_sent_string = "sent" | ||
| else: | ||
| move.is_move_sent_string = "not_sent" |
There was a problem hiding this comment.
Suggested change
| if move.is_move_sent: | |
| move.is_move_sent_string = "sent" | |
| else: | |
| move.is_move_sent_string = "not_sent" | |
| move.is_move_sent_string = 'sent' if move.is_move_sent else 'not_sent' |
In the account module, we want to help customers visualize which invoice has been sent or not. task-5231288
jedel-odoo
force-pushed
the
18.0-rd-accounting-onboarding-sent-status-jedel
branch
from
011e0b2 to
c72bfe9
Compare
malb-odoo
reviewed
Nov 7, 2025
| /> | ||
| <filter name="sent" | ||
| string="Sent Invoices" | ||
| domain="[('is_move_sent', '=', True)]" |
There was a problem hiding this comment.
Check the not_sent filter, why not using the invisible 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the account module, we want to help customers visualize which invoice
has been sent or not.
task-5231288