[IMP] orm: add warning about model extension

[emi-odoo]

When a model is defined with _inherit using a list, Odoo will do a check with the class name to set the _name of the model being extended. This is different than the previous versions and can be misleading

[robodoo]

[emi-odoo]

@robodoo r+

[robodoo]

@emi-odoo you can't review+.

[emi-odoo]

@kmagusiak I r+ too soon lol
Are you the one supposed to r+ or to delegate it?

[kmagusiak]

@kmagusiak I r+ too soon lol Are you the one supposed to r+ or to delegate it?

I cannot. @Julien00859 or @HydrionBurst

[Julien00859]

Can you make another commit to fix the indentation, so we can backport that commit? Also we can't r+ it, we need someone from the documentation team

[emi-odoo]

@Julien00859 you mean the indentation for the code examples of inheritance? If yes: will do 🫡

[Julien00859]

Hello there @odoo/be-doc-review 👋 this PR is ready :)

[emi-odoo]

@Julien00859 -> I force pushed as I needed to resplit the work on the two commits (one for the warning and one for the code examples)

[HydrionBurst]

we raise a warning _logger.warning("Class %s has no _name, please make it explicit: _name = %r", name, attrs['_name']) when infer model name from class name. So I think developers shouldn't use this feature. And we don't have to document it here which increase the complexity.

Suggested change

	the attribute itself or by the class name (i.e: ``class MyModel(models.Model)`` will be
	translated into ``_name = 'my.model'``, even if not explicitly set)
	In all the other cases you need to explicity set the :attr:`~odoo.models.Model._name`.

[emi-odoo]

I had developers being confused anyways because in the code example we're using _inherit = [...] (at least before this PR we were). And they didn't notice the class name. For new devs I think it's easy to get confused of the relationship between the class name and the model name and the table name. People will try to do it even if they don't realize what they're doing, so, from my point of view, it's better to explicitly explain what's going on in case they make a mistake :)

[Julien00859]

Suggested change

	the attribute itself or by the class name (i.e: ``class MyModel(models.Model)`` will be
	translated into ``_name = 'my.model'``, even if not explicitly set)
	.. warning:: When :attr:`~odoo.models.Model._inherit` is set to a string,
	then :attr:`~odoo.models.Model._name` is set to the same value,
	unless `_name` is explicitly set.

[HydrionBurst]

I would simplify everything, the description of inhertance is also not accurate.

Inheritence
_name is not any _inherit

_name = 'a'
_inherit = 'b'

_name = 'a'
_inherit = ['b']

_name = 'a'
_inherit = ['b', 'c']

Extension
_name is one of _inherit and doesn't have to be specified only when _inherit is a str

_inherit = 'a'

_name = 'a'
_inherit = 'a'

_name = 'a'
_inherit = ['a']

Delegation
_inherits

[emi-odoo]

I agree, but maybe this could be for another task/PR, what do you think?

[HydrionBurst]

No problem, it is already much better than before.

BTW, I think the message shouldn't be a warning 🤔

And the Note in the next line is for the content {'name': "A", 'description': "Extended"} in the previous line.
So we shouldn't add this content in between.

I would do

{'name': "A", 'description': "Extended"}. # It will also yield .....

Note: your new content

[emi-odoo]

@HydrionBurst a note would suffice! After the rephrasing especially :D

will check the format this evening :D

[emi-odoo]

@Julien00859 @HydrionBurst -> adapted using JUC's suggestion! I feel like we still have the chance to confuse devs but better than before :D

[xpl-odoo]

@robodoo delegate+
@emi-odoo feel free to r+ whenever ;)