[FIX] Spreadsheet: Fix zoom on Safari #7421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
rrahir
force-pushed
the
master-fix-safari-zoom-rar
branch
from
2a93e4d to
79690d4
Compare
rrahir
force-pushed
the
master-fix-safari-zoom-rar
branch
from
79690d4 to
4238f3e
Compare
rrahir
commented
Nov 12, 2025
|
|
||
| const gridWidth = | ||
| this.spreadsheetRef.el?.querySelector(".o-grid")?.getBoundingClientRect().width || 0; | ||
| (this.spreadsheetRef.el?.getBoundingClientRect().width || 0) - |
Collaborator
Author
There was a problem hiding this comment.
there is a non negligeable chance that the o-row-group should be taken into account as well
The highlight component was not using the zoomedMouseEvent to compute its starting position to move a highlight, which means the highlight would 'jump' when trying to move it. Task: 5232092
rrahir
force-pushed
the
master-fix-safari-zoom-rar
branch
from
4238f3e to
b7186b2
Compare
The new zoom feature relies on the zoom css property, however there is a long standing bug in webkit (https://bugs.webkit.org/show_bug.cgi?id=77998) that impacts the computation of `Element.getBoundingClientRect`. This revision adds a check on safari browser to correct the boundingRect at specific points (pretty much where we handle mouseEvents). Task: 5232092
rrahir
force-pushed
the
master-fix-safari-zoom-rar
branch
from
b7186b2 to
f48fd94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5232092
review checklist