Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 19, 2025

Description:

Current behavior before PR:

  • When typing =sum( and pressing the Home key, selecting a range caused weird
    behavior in the composer.
  • The same issue occurred when using Ctrl+A to select the entire text.

Desired behavior after PR is merged:

  • Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7475
Forward-Port-Of: #7400

@robodoo
Copy link
Collaborator

robodoo commented Nov 19, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 19, 2025

@rmbh-odoo @VincentSchippefilt cherrypicking of pull request #7400 failed.

stdout:

Auto-merging src/components/composer/composer/abstract_composer_store.ts
CONFLICT (content): Merge conflict in src/components/composer/composer/abstract_composer_store.ts
Auto-merging src/components/composer/composer/composer.ts
Auto-merging src/helpers/pivot/pivot_composer_helpers.ts
Auto-merging tests/composer/autocomplete_dropdown_component.test.ts
Auto-merging tests/composer/composer_store.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

… changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615
X-original-commit: e3c5dea
@rmbh-odoo rmbh-odoo force-pushed the saas-18.2-17.0-fix-composer-range-selection-rmbh-478033-fw branch from 24a1db5 to fcdcec2 Compare November 19, 2025 04:57
@rmbh-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 19, 2025
… changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

closes #7483

Task: 5226615
X-original-commit: e3c5dea
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>
@robodoo robodoo closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants