Skip to content

Fix group listing: don't add root every time #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix group listing: don't add root every time #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,10 +749,12 @@ pub fn group_access_list() -> io::Result<Vec<Group>> {
Err(io::Error::last_os_error())
}
else {
let mut groups = buff.into_iter()
buff.truncate(res as usize);
buff.sort_unstable();
buff.dedup();
let groups = buff.into_iter()
.filter_map(get_group_by_gid)
.collect::<Vec<_>>();
groups.dedup_by_key(|i| i.gid());
Ok(groups)
}
}
Expand Down Expand Up @@ -800,7 +802,11 @@ pub fn get_user_groups<S: AsRef<OsStr> + ?Sized>(username: &S, gid: gid_t) -> Op
None
}
else {
buff.truncate(count as usize);
buff.sort_unstable();
buff.dedup();
// allow trivial cast: on macos i is i32, on linux it's already gid_t
#[allow(trivial_numeric_casts)]
buff.into_iter()
.filter_map(|i| get_group_by_gid(i as gid_t))
.collect::<Vec<_>>()
Expand Down