fix: binop minus without space #152
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the bug that the expression
42-51fails to parse, because the tokenizer greedily treats-51as being a number token.Closes #133
How
Move the lexer definitions for
intandfloatto be below theop_minusdefinition. This changes the precedence so that the lexer emits a unary minus followed by an integer, rather than emitting a single negative-integer token.Update tests in
src/lexer.spec.tsto expect this.Update tests in
src/syntax/expr.spec.tsto expect the resulting wrapping of integer literals withtype: unaryAST nodes. In particular, replace the incorrect assertioncheckInvalidExpr('42.-51');with one expecting abinaryAST node because that expression is valid.Change the parser definitions
expr_memberandsimplestatements_set_timezone_valto parse the unary-followed-by-integer token sequence as a negative integer, as that is the only thing that makes sense in those expressions, and it limits the footprint of the change.