Fix panic with an invalid filter expression that did not specify "valid parentheses syntax" #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, it had a panic in a filter expression without parentheses.
fix panic in a filter expression without parentheses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, there was a panic when a JSON path with an invalid filter expression that did not specify "valid parentheses syntax" was specified.
A normal error should be returned for these syntax errors.
example:$.somewhere[?$ .somewhere]
** I made the child pull request based on peter-jozsa's modifications to pull requests 21-23, so please let me complete the review of that one first.