Skip to content

Small changes #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
katajakasa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Small changes #1174

katajakasa wants to merge 3 commits into from

Conversation

@katajakasa
Copy link
Member

@katajakasa katajakasa commented Apr 9, 2025

No description provided.

@Vagabond
Copy link
Member

Vagabond commented Apr 9, 2025

Congratulations for breaking so many rectests, that looks like a record.

@LegendaryBlueShirt
Copy link
Contributor

LegendaryBlueShirt commented Apr 9, 2025

If it's any consolation, this does fix my issue with Nova's 4P

@LegendaryBlueShirt LegendaryBlueShirt linked an issue Apr 9, 2025 that may be closed by this pull request
[GAMEPLAY] First Tick Skipped For Attacks (All animations?) #1173
Open
LegendaryBlueShirt
LegendaryBlueShirt requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@LegendaryBlueShirt LegendaryBlueShirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently Jaguar scrap, chronos matter phasing and katana wall spin are busted so I can't fix the rectests for those.

Jaguar Scrap - If the other HAR is too far away Jaguar will give up and resume victory pose
Chronos, Katana - Matter Phasing and Wall Spin do not flip around to go the other way

@katajakasa
Copy link
Member Author

katajakasa commented Apr 10, 2025 •
edited
Loading

Currently Jaguar scrap, chronos matter phasing and katana wall spin are busted so I can't fix the rectests for those.

Jaguar Scrap - If the other HAR is too far away Jaguar will give up and resume victory pose Chronos, Katana - Matter Phasing and Wall Spin do not flip around to go the other way

This is likely not the solution we want. Some other plan is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LegendaryBlueShirt LegendaryBlueShirt LegendaryBlueShirt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GAMEPLAY] First Tick Skipped For Attacks (All animations?)

4 participants

@katajakasa @Vagabond @LegendaryBlueShirt