feat: add support for x-forwarded-host#68
Conversation
dinoboff
force-pushed
the
fix/67
branch
3 times, most recently
from
fe6f66c to
4e31b36
Compare
|
Changes Unknown when pulling 4e31b36 on dinoboff:fix/67 into ** on omsmith:master**. |
dinoboff
force-pushed
the
fix/67
branch
2 times, most recently
from
bb92b1a to
420de9d
Compare
|
Changes Unknown when pulling 420de9d on dinoboff:fix/67 into ** on omsmith:master**. |
|
Changes Unknown when pulling 420de9d on dinoboff:fix/67 into ** on omsmith:master**. |
|
Changes Unknown when pulling a2b1ed5 on dinoboff:fix/67 into ** on omsmith:master**. |
|
Ready for review. Note that it's my first PR using coffee script; please point to missing coffeeish idioms. |
|
I published it as a scoped package: https://www.npmjs.com/package/@dinoboff/ims-lti (I don't think npm can install the fork directly from github). |
Adds `trustProxy` option to HMAC_SHA1 and Provider constructor.
It overloads the Provider constructor with the third argument being either a nonceStore or an options object (for a nonceStore, a signer and the trustProxy flag):
new Provider(key: string, secret: string, options: NonceStore|Options, signer: Algo)
|
Changes Unknown when pulling 72c513a on dinoboff:fix/67 into ** on omsmith:master**. |
|
@dinoboff, thanks for your contribution. I tried to solve the issue checking the header before noticing your pull request. I think we need a more stable node library (I have nothing against Coffee, only that I haven't used it before). |
3 participants
Adds
trustProxyoption to HMAC_SHA1 and Provider constructor.It overloads the Provider constructor with the third argument being either a nonceStore or an options object (for a nonceStore, a signer and the trustProxy flag):