Fix missing subdirectories in PyPI builds by correcting package exclusion pattern #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyPI build for version 3.2.0 was missing the
api/andmodels/subdirectories, causing import errors like:Root Cause
The issue was in the
pyproject.tomlsetuptools configuration where the package exclusion pattern was incorrect:The pattern was looking for directories starting with "tests" but the actual test directory is named "test" (singular). This caused:
Solution
Updated the exclude pattern to match the actual directory name. This ensures:
onelogin.apipackage (25 API modules) is included in buildsonelogin.modelspackage (161 model files) is included in buildsonelogin.saml2package is included in buildsVerification
Built and tested both source and wheel distributions:
setuptools.find_packages()Fixes #105.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.