Multi position per user scenarios testing by mts1715 · Pull Request #172 · onflow/FlowALP

mts1715 · 2026-02-19T13:48:46Z

Closes: #147

Multi-Position Per User Scenarios: Fork Tests & Supporting Infrastructure
cadence/tests/fork_multiple_positions_per_user.cdc
Runs against mainnet at block 142528994 using real token holders and real token identifiers (FLOW, USDF, USDC, WETH, WBTC). Contains 4 tests:

testMultiplePositionsPerUser — Creates 5 positions with different collateral types, borrows varying amounts from each, and asserts that operations on one position do not affect the health factors of others (isolation guarantee).
testPositionInteractionsSharedLiquidity — Verifies cross-position effects through the shared FLOW liquidity pool: Position A's heavy borrowing reduces available liquidity for Position B, a subsequent repayment restores it, and a crash of Position A's collateral price has zero effect on Position B's health.
testBatchLiquidations — Creates 5 positions (USDF, WETH, USDC, WBTC, FLOW) with differentiated borrow levels, crashes 4 collateral prices, then executes a single-transaction batch liquidation: 2 full liquidations (WETH, USDF) and 2 partial liquidations (USDC, WBTC). The FLOW-collateral position, whose price is unchanged, remains untouched.
testMassUnhealthyLiquidations — System-wide stress test: 100 positions across 3 collateral types (50 USDF × 10 USDF, 45 USDC × 2 USDC, 5 WBTC × 0.00009 WBTC), two risk tiers (high/moderate) per stablecoin group, simultaneous 40% price crash across all three collateral types, then batch DEX liquidation of all 100 positions in chunks of 10 to stay within computation limits. Verifies all positions recover health and protocol FLOW reserve stays positive.

cadence/transactions/flow-alp/pool-management/batch_manual_liquidation.cdc — Liquidates multiple positions in one transaction using the caller's own debt tokens as repayment.

cadence/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc — Liquidates multiple positions in one transaction sourcing repayment from a pre-configured MockDexSwapper.

…dation - fork_multiple_positions_per_user.cdc covering three scenarios: - Multiple positions with distinct collateral types (FLOW, USDF, USDC, WETH, WBTC) and isolation guarantees between them - Cross-position effects through shared liquidity pools - Batch liquidation of 4 positions (2 full, 2 partial) in a single tx

…eates 100 positions across three collateral types (50 USDF, 45 USDC, 5 WBTC), crashes all collateral prices 40% simultaneously, and batch-liquidates all positions via MockDexSwapper in chunks of 10 to stay within computation limits.

…ion-per-user-scenarios-testing # Conflicts: # flow.json

cadence/tests/fork_multiple_positions_per_user_test.cdc

cadence/tests/fork_multiple_positions_per_user.cdc

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

Co-authored-by: patrick <72362902+holyfuchs@users.noreply.github.com>

…on flow.json hash

cadence/tests/transactions/flow-alp/pool-management/batch_manual_liquidation.cdc

…testing

…testing # Conflicts: # cadence/tests/test_helpers.cdc # flow.json

nialexsan

a few nits

nialexsan · 2026-03-06T16:11:02Z

cadence/tests/transactions/flow-alp/pool-management/batch_manual_liquidation.cdc

+/// repayAmounts: Array of repay amounts for each position
+transaction(
+    pids: [UInt64],
+    debtVaultIdentifier: String,


change debt* to repayment* to reduce confusion as it represents a repayment, not actual the actual debt

nialexsan · 2026-03-06T16:14:04Z

cadence/tests/transactions/flow-alp/pool-management/batch_manual_liquidation.cdc

+            // Deposit seized collateral back to liquidator
+            // For simplicity, we'll just destroy it in this test transaction
+            // In production, you'd want to properly handle the seized collateral
+            destroy seizedVault


depositing it back to liquidator would improve testing, as it'd be possible to check the vault balance after liquidation

nialexsan · 2026-03-06T16:14:42Z

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

+/// repayAmounts: Array of debt amounts to repay for each position (sourced from the DEX)
+transaction(
+    pids: [UInt64],
+    debtVaultIdentifier: String,


change debt* to repayment*

nialexsan · 2026-03-06T16:15:15Z

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

+            )
+
+            totalRepaid = totalRepaid + repayAmount
+            destroy seizedVault


deposit back to liquidator to improve test assertions

yeah, better not to destroy, just finish up by depositing somewhere ideally.

nialexsan · 2026-03-06T16:21:39Z

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

+
+            // Build an exact quote for the repayAmount we need from the swapper's vaultSource
+            let swapQuote = MockDexSwapper.BasicQuote(
+                inType: seizeType,


nit: it's slightly awkward to swap seizeType to debtType in order to get back seizeType back from liquidator. It would be better to use something like FlowToken or another token to clearly demonstrate that the debt could be repaid with any other token, not just debtType

nialexsan · 2026-03-06T16:32:02Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+//   pid 1: 0.06 WETH   @ $3500  (CF=0.75), borrow  90 → health = 0.06*3500*0.75/90   = 1.750
+//   pid 2:   80 USDC   @ $1.00  (CF=0.85), borrow  40 → health = 80*1.0*0.85/40      = 1.700
+//   pid 3: 0.0004 WBTC @ $50000 (CF=0.75), borrow  10 → health = 0.0004*50000*0.75/10 = 1.500
+//   pid 4:  200 FLOW   @ $1.00  (CF=0.80), borrow  80 → health = 200*1.0*0.80/80     = 2.000


technically this will be collateral withdrawal, not borrowing
put FLOW, get FLOW back

then should we just remove?

nialexsan · 2026-03-06T16:41:04Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+// 40% simultaneously, requiring a chunked batch DEX liquidation of every position.
+//
+// =============================================================================
+access(all) fun testMassUnhealthyLiquidations() {


would it be possible to store the ranges in some variables instead of using magic numbers through the test, even with comments it's tricky to track all of them

…testing

Kay-Zee · 2026-03-06T17:40:53Z

cadence/scripts/flow-alp/get_oracle_price.cdc

@@ -0,0 +1,9 @@
+import "MockOracle"


can we name this something else? or move into a scripts folder in the tests section, since this only grabs from the MockOracle.

Kay-Zee · 2026-03-06T22:13:00Z

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

+    debtVaultIdentifier: String,
+    seizeVaultIdentifiers: [String],
+    seizeAmounts: [UFix64],
+    repayAmounts: [UFix64]


not needed for this PR, but i do wonder if this should be a single array of a.composite data structure or even map, rather than 4 separate arrays, since this adds 3 asserts, and slightly more complex for loop notion. for idx in InclusiveRange(0, numPositions - 1) {

mostly a nit though, so up to you if it's easy to adjust in this PR, or to just keep in mind for the future

Kay-Zee · 2026-03-06T22:14:10Z

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc

+            )
+
+            totalRepaid = totalRepaid + repayAmount
+            destroy seizedVault


yeah, better not to destroy, just finish up by depositing somewhere ideally.

Kay-Zee · 2026-03-06T22:18:10Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+        depositCapacityCap: 1_000_000.0
+    )
+
+    addSupportedTokenZeroRateCurve(


Dete actually has mentioned that he's aiming to NOT allow other stables as collateral in the protocol. I think if we do want to keep one stable, it's probably okay, but we def don't need 2 i think. If it's easy to remove, let's just do 1 stable coin only.

Kay-Zee · 2026-03-06T22:21:00Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+//   pid 1: 0.06 WETH   @ $3500  (CF=0.75), borrow  90 → health = 0.06*3500*0.75/90   = 1.750
+//   pid 2:   80 USDC   @ $1.00  (CF=0.85), borrow  40 → health = 80*1.0*0.85/40      = 1.700
+//   pid 3: 0.0004 WBTC @ $50000 (CF=0.75), borrow  10 → health = 0.0004*50000*0.75/10 = 1.500
+//   pid 4:  200 FLOW   @ $1.00  (CF=0.80), borrow  80 → health = 200*1.0*0.80/80     = 2.000


then should we just remove?

Kay-Zee · 2026-03-06T22:23:55Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+        inVaultIdentifier: MAINNET_USDF_TOKEN_ID,
+        outVaultIdentifier: MAINNET_FLOW_TOKEN_ID,
+        vaultSourceStoragePath: FLOW_VAULT_STORAGE_PATH,
+        priceRatio: 0.3     // $0.30 USDF / $1.00 FLOW


nit: $1.00 FLOW is a token count right? let's remove the $ if so

Kay-Zee · 2026-03-06T22:27:09Z

cadence/tests/fork_multiple_positions_per_user_test.cdc

+    // and 1 unit of each collateral token to initialize vault storage paths.
+    //
+    // Repay amounts derived from: repay = debt - (collat - seize) * CF * P_crashed / H_target
+    //   WETH=71:  debt=90,  (0.06-0.035)*0.75*1050 = 19.6875, H≈1.034 → 90  - 19.6875/1.034 ≈ 71


You mention it a bit below but might be good to mention where 1.034 comes from

mts1715 added 4 commits February 18, 2026 20:24

Merge remote-tracking branch 'origin/main' into taras/147-multi-posit…

bf31254

…ion-per-user-scenarios-testing # Conflicts: # flow.json

fixes after merge

441c58e

mts1715 requested a review from a team as a code owner February 19, 2026 13:48

mts1715 added 2 commits February 19, 2026 15:06

code style fix

86086fa

constant naming fix

526704a

mts1715 self-assigned this Feb 20, 2026

holyfuchs reviewed Feb 23, 2026

View reviewed changes

cadence/tests/fork_multiple_positions_per_user_test.cdc Show resolved Hide resolved

cadence/tests/fork_multiple_positions_per_user.cdc Outdated Show resolved Hide resolved

cadence/tests/transactions/flow-alp/pool-management/batch_liquidate_via_mock_dex.cdc Show resolved Hide resolved

moved helper methods to test_helpers.cdc

13c50e5

vishalchangrani requested a review from a team February 24, 2026 17:20

mts1715 mentioned this pull request Feb 25, 2026

Liquidation edge cases #181

Open

mts1715 and others added 5 commits February 25, 2026 16:51

Update cadence/tests/fork_multiple_positions_per_user.cdc

e7216bd

Co-authored-by: patrick <72362902+holyfuchs@users.noreply.github.com>

fix naming *_test.cdc, move not production script to test dir

d064bc7

flow.json: fix block height

887ae21

fix block height in flow.json, add actions/cache for ./imports keyed …

0df9e00

…on flow.json hash

add more description comments to test

c9cc894

holyfuchs reviewed Feb 26, 2026

View reviewed changes

cadence/tests/transactions/flow-alp/pool-management/batch_manual_liquidation.cdc Show resolved Hide resolved

mts1715 added 2 commits February 26, 2026 13:25

move scripts only for test to "cadence/test/transactions"

0e5577c

remove useless transaction from test

5bc3cf1

holyfuchs approved these changes Feb 26, 2026

View reviewed changes

mts1715 added 2 commits March 2, 2026 16:35

Merge branch 'main' into taras/147-multi-position-per-user-scenarios-…

8fd216c

…testing

Merge branch 'main' into taras/147-multi-position-per-user-scenarios-…

e5e5824

…testing # Conflicts: # cadence/tests/test_helpers.cdc # flow.json

mts1715 requested review from Kay-Zee, jordanschalm, nialexsan and zhangchiqing March 4, 2026 09:38

nialexsan reviewed Mar 6, 2026

View reviewed changes

Merge branch 'main' into taras/147-multi-position-per-user-scenarios-…

d7cefa5

…testing

Kay-Zee reviewed Mar 6, 2026

View reviewed changes

Conversation

mts1715 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nialexsan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mts1715 commented Feb 19, 2026 •

edited

Loading