Skip to content

Conversation

@rolu01
Copy link
Member

@rolu01 rolu01 commented Nov 28, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the codebase by bumping various packages, updating Node.js to version 20, and migrating to modern JavaScript import syntax. The changes span dependency updates, CI/CD workflow improvements, and standardization of package configurations across test modules.

Key Changes:

  • Upgraded Node.js from 18 to 20 across CI/CD workflows and package dependencies
  • Updated import attribute syntax from assert to with for JSON imports (TC39 standard)
  • Major version bumps for testing framework (vitest 0.34.6 → 4.0.14) and database driver (mssql 10.0.1 → 12.1.1)

Reviewed changes

Copilot reviewed 10 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Bumped version to 2.0.2 and upgraded vitest to v4.0.14
src/start.js Updated JSON import syntax to use with keyword and added trailing commas for consistency
src/lib/setup-app.js Updated JSON import syntax and reformatted port assignment
src/modules/mssql/v1/package.json Upgraded mssql from v10.0.1 to v12.1.1
src/modules/mssql/v1/package-lock.json Full dependency tree update for mssql major version upgrade
test/*/v1/package.json Added "imports" field with path mapping to source directory
test/*/v1/package-lock.json Updated dependency versions including form-data, fast-xml-parser, and supporting packages
.github/workflows/*.yaml Updated to Node.js 20, GitHub Actions v4, and google-github-actions v2 with modernized auth
README.md Improved npm install command to show installation progress
Files not reviewed (6)
  • src/modules/convert/v1/package-lock.json: Language not supported
  • src/modules/dustin/v1/package-lock.json: Language not supported
  • src/modules/excel/v1/package-lock.json: Language not supported
  • src/modules/mssql/v1/package-lock.json: Language not supported
  • test/dustin/v1/package-lock.json: Language not supported
  • test/excel/v1/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@rolu01 rolu01 merged commit 9696edd into main Nov 28, 2025
8 checks passed
@rolu01 rolu01 deleted the bump-packages branch November 28, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants