Unit tests for \OnMoon\OpenApiServerBundle\Controller\ApiController #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@egorzot please improve coverage |
sspat
requested changes
Dec 28, 2020
| return new class implements SetRequest, RequestHandler { | ||
| public function setRequest(Request $request): void | ||
| { | ||
| throw new Exception('test request was set'); |
Contributor
There was a problem hiding this comment.
This can be tested without exceptions, by creating a getter on this class and asserting that it returns the expected response object after the controller is executed.
| return new class implements SetClientIp, RequestHandler { | ||
| public function setClientIp(string $ip): void | ||
| { | ||
| throw new Exception('test ip was set'); |
Contributor
There was a problem hiding this comment.
This can be tested without exceptions, by creating a getter on this class and asserting that it returns the expected ip address after the controller is executed.
|
|
||
| $this->expectException(Throwable::class); | ||
| $this->expectException(Throwable::class); | ||
| $this->expectExceptionMessage('"TestClass" has 0 public methods, exactly one expected'); |
Contributor
There was a problem hiding this comment.
Maybe an anonymous class can be used here and get_class to assert it's name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148