-
Notifications
You must be signed in to change notification settings - Fork 23
Feature: Add all MOD metadata feilds to the submission object #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add all MOD metadata feilds to the submission object #18
Conversation
18e41c5 to
a84ed2d
Compare
a84ed2d to
0e56795
Compare
eab25f7 to
0622986
Compare
| #Name => Ontology object (omv:name) | ||
|
|
||
| #URI | ||
| URI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be downcase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in ncbo@fe9c6f4
| "DOAP: ISO language code a project has been translated into.", | ||
| "SCHEMA: The language of the content or performance or used in an action. Please use one of the language codes from the IETF BCP 47 standard." ] | ||
| extractedMetadata: true | ||
| enforcedValues: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to be updated to not use "http://lexvo.org/id/iso639-1/'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in ncbo@fe9c6f4
conflicts Feature: Add all MOD metadata fields to the submission object ontoportal#18
| attribute :hiddenLabel, namespace: :skos, type: :list | ||
| attribute :alternative, namespace: :dct, type: :list | ||
| attribute :abstract, namespace: :dct | ||
| attribute :publication, type: %i[uri list] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the data type of publication attribute is changed to a list. This requires updating the UI to accommodate this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in ncbo/bioportal_web_ui@2447a8a
|
submission_validators lacks unit test |
Changes