refactor: PR#4[option_1] drop is_positive column #5944
Draft
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
This completes the migration from boolean is_positive to enum-based feedback. Can be merged directly into Stage 1 (whuang/refactor-chat-feedback-enums).
wenxi-onyx
force-pushed
the
whuang/drop-is-positive-column
branch
from
9bdcdcd to
c4ce50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes the migration from boolean is_positive to enum-based feedback. Can be merged directly into Stage 1 (whuang/refactor-chat-feedback-enums).
NOTE: this may also be merged onto stage 2b --> #5943
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Additional Options
Summary by cubic
Drops the deprecated is_positive column and completes the move to enum-based chat feedback. Simplifies the data model and removes the dual source of truth.