fix: jira connector creation

[evan-onyx]

Description

connector creation didnt work when specifying a JQL query due to some modifications for supporting the v3 API.

How Has This Been Tested?

tested in the UI; testing this fully would require a somewhat heavyweight playwright test

Additional Options

• [Optional] Override Linear Check

---

Summary by cubic

Fixes Jira connector creation when a JQL query is specified. Adds the missing all_issue_ids parameter to the v3 search call so settings validation succeeds.

• Bug Fixes
  • Pass all_issue_ids=[] to search_issues in validate_connector_settings (v3 API requirement).

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
internal-search	Ready	Preview	Comment	Oct 28, 2025 6:34pm

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed Jira connector creation failure when specifying a JQL query for cloud Jira instances (v3 API).

• Added missing all_issue_ids=[] parameter to _perform_jql_search() call in validate_connector_settings() on line 647
• The v3 API requires all_issue_ids to be provided (not None), which was causing a ValueError during validation
• Empty list is appropriate for validation - the function will fetch IDs but skip bulk fetch, successfully validating the JQL query syntax

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is a simple one-line addition that addresses a clear bug. The solution correctly provides the required parameter for v3 API compatibility without affecting existing functionality. All other call sites already pass this parameter correctly, and the empty list is the appropriate value for validation purposes.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
backend/onyx/connectors/jira/connector.py	5/5	Added missing all_issue_ids=[] parameter to v3 API search call in validate_connector_settings - fixes connector creation with JQL queries

Sequence Diagram

sequenceDiagram
    participant User
    participant JiraConnector
    participant _perform_jql_search
    participant _perform_jql_search_v3
    participant enhanced_search_ids
    
    User->>JiraConnector: validate_connector_settings()
    JiraConnector->>JiraConnector: Check if jql_query is set
    JiraConnector->>_perform_jql_search: call with jql, max_results=1, all_issue_ids=[]
    _perform_jql_search->>_perform_jql_search: Check if cloud client (v3)
    alt Cloud Client (v3 API)
        _perform_jql_search->>_perform_jql_search: Validate all_issue_ids is not None
        _perform_jql_search->>_perform_jql_search_v3: Forward call
        _perform_jql_search_v3->>enhanced_search_ids: Fetch issue IDs (ids_done=False)
        enhanced_search_ids-->>_perform_jql_search_v3: Return issue IDs
        _perform_jql_search_v3->>_perform_jql_search_v3: Check if all_issue_ids (empty list = False)
        Note over _perform_jql_search_v3: No bulk fetch for empty list
        _perform_jql_search_v3-->>_perform_jql_search: Return issues (none)
    else Server/Data Center (v2 API)
        _perform_jql_search->>_perform_jql_search_v2: Forward call
        _perform_jql_search_v2-->>_perform_jql_search: Return issues
    end
    _perform_jql_search-->>JiraConnector: Validation succeeds
    JiraConnector-->>User: Connector settings valid

Loading

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cubic-dev-ai]

No issues found across 1 file

[wenxi-onyx]

@evan-onyx Joke comment not withstanding. Any chance you can add a test for the JQL config flow?