Polynomial #162
Open
Polynomial #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved test build configuration to improve modularity and added support in InFixSerializer for new types (e.g., Matrix, EulerNumber, Pi, Magnitude). Introduced `Common.hpp` for shared test macros, enabling serializer-based assertions. Adjusted tests accordingly to utilize the new serializer functionality.
# Conflicts: # tests/AddTests.cpp # tests/CMakeLists.txt # tests/Common.hpp # tests/PolynomialTests.cpp
… a perfect number.
…ynomial # Conflicts: # tests/Common.hpp
matthew-mccall
requested changes
Feb 25, 2025
Collaborator
matthew-mccall
left a comment
matthew-mccall
left a comment
There was a problem hiding this comment.
Remove all logging, and any commented out code.
CMAKE_ON_WINDOWS check
CMAKE_ON_WINDOWS check
matthew-mccall
requested changes
Mar 14, 2025
Collaborator
matthew-mccall
left a comment
matthew-mccall
left a comment
There was a problem hiding this comment.
Looks good, just add a check that all variables are the same
4 tasks
matthew-mccall
moved this from In Progress
to Needs New Owner
in OASIS Core Feature Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polynomial:
Linear done;
Quadratic Cubic can solve the fraction and perfect number solutions