-
Notifications
You must be signed in to change notification settings - Fork 29
Feature palm serializer #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CodingPupper3033
wants to merge
30
commits into
open-algebra:master
Choose a base branch
from
CodingPupper3033:feature-palm-serializer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature palm serializer #191
CodingPupper3033
wants to merge
30
commits into
open-algebra:master
from
CodingPupper3033:feature-palm-serializer
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingPupper3033
commented
Nov 8, 2025
io/src/PALMConst.hpp
Outdated
| }; | ||
|
|
||
| // Define PALM tokens | ||
| constexpr inline std::string_view PALM_OPEN_PARENS = "("; |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you like refactor all of these to the ones above? (In FromPalm)
99a8452 to
46293d7
Compare
58a2bcd to
a64b226
Compare
Contributor
Author
|
The Serializer (and tests) should be refactored now. PS: Oasis-Jetbrains should be updated to accept Infinity -Infinity and NaN |
…plement serialization for Log, Negate, Derivative, Integral, and Magnitude
…odify PALMHelper.hpp to define TokenBimap for expression type mapping
… by type (operators and delimiters). Also refactored the helper functions to use the new feature. Also split the separators between the start/end parenthesis and between operands into two separate delimiters (so in the future we could do something like (+ 5 2) instead of needing to be ( + 5 2 )
….hpp Created PALMTokenizer to tokenize the input string. (By whitespace or punctuators)
…e (LeafExpression, BinaryExpression, UnaryExpression).
…zation error types, and refactor WrapExpression parameters
…onsistency in naming, and enhanced error handling
…n operand handling
b963c9c to
58b0a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to serialize an expression to the PALM prefix notation