fix: remove duplicate method due to rebasing error#825
Merged
kaustavb12 merged 1 commit intoviadanna/teak/offlinefrom Feb 26, 2026
Merged
fix: remove duplicate method due to rebasing error#825kaustavb12 merged 1 commit intoviadanna/teak/offlinefrom
kaustavb12 merged 1 commit intoviadanna/teak/offlinefrom
Conversation
kaustavb12
force-pushed
the
kaustav/fix_mobile_api
branch
from
b75710d to
ca4f2d0
Compare
Member
|
Approved 👍
I see a few tests failing coming from the offline code. Is this expected given the WIP state of the project? |
viadanna
approved these changes
Feb 26, 2026
Member
Author
|
Thanks for the review.
I see test cases failing for the upstream PRs too openedx#36409 and raccoongang#2590, so I think it is due to the WIP state of the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a duplicate method which was breaking the mobile api, and which was presumably caused due to rebasing error.
For reference, here's the changes from the original PR which was ported.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
BB-10376