Handle Database Cancelled Queries (a.k.a. DB Timeouts)

[JVickery-TBS]

fix(logic): catch db timeouts;

• Handle database query timeouts and close tmp files.

[wardi]

it's usually a good pattern to use a context manager or try: finally: to make sure resources like temp files are always closed.

Here you're closing the file within a closure that wasn't responsible for creating the file, or even passed it as a parameter. That's a little confusing and it's hard to see that the file will always be closed by looking at the code.

[JVickery-TBS]

@wardi yeah the temp file comes from XLoader's _download_resource_data method, which returns the file like object and file hash as a tuple.

I kind of just coded it the same as the rest of XLoader is coded, which I guess is not great if all these try/catches and file closing is happening in enclosure methods??

But I see at the end of the method, upstream has the tmp_file.close(). So I have now put that into the finally. So if an Exception is raised the finally: tmp_file.close() will get run still right?