Draft
Conversation
scottmbaker
reviewed
Aug 7, 2025
| annotations := watcherObj.GetAnnotations() | ||
| currentTag := "" | ||
| if annotations != nil { | ||
| currentTag = annotations[ManifestTagAnnotationKey] |
Contributor
There was a problem hiding this comment.
what happens if annotations[ManifestTagAnnotationKey] is not present?
| log.Infof("Watch %s for project %s already provisioned but manifest tag needs update. Have '%s', want '%s'", | ||
| watcherObj.DisplayName(), project.DisplayName(), currentTag, expectedTag) | ||
| action = "update" | ||
| } else if currentTag != expectedTag { |
Contributor
There was a problem hiding this comment.
Can we add a comment differentiating how the update in this if statement is different from the previous one? Not sure why we need both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
orchestrator upgrade fix for application version
Changes
The solution make sure application versions get updated after orchestrator upgrade
Additional Information
Include any additional information, such as how to test your changes.
Checklist