Skip to content

Documentation for GPO trigger and stimulator reports #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: issue-272
Choose a base branch
from
Open

Documentation for GPO trigger and stimulator reports #289

wants to merge 4 commits into from

Conversation

@cjsha
Copy link
Member

@cjsha cjsha commented Oct 30, 2025 •
edited
Loading

Fix #286 Fix #287

@cjsha cjsha requested review from bparks13 and jonnew October 30, 2025 20:06
@bparks13
Copy link
Member

bparks13 commented Oct 30, 2025

@cjsha couple things I noticed;

  1. Issue 236 was closed a while ago, did you mean to say this fixes Document GPOTrigger #286?
  2. There is an open PR to fix Broken link in api/overview.md #280 (Fix broken link to InterPulseInterval property #283)
  3. It looks like the submodule might not be pointing to the correct commit, the build failed saying the workflow has unknown types

bparks13
bparks13 reviewed Oct 30, 2025
View reviewed changes
@cjsha cjsha changed the base branch from main to issue-272 October 30, 2025 20:36
@cjsha
Copy link
Member Author

cjsha commented Oct 30, 2025

  1. Issue 236 was closed a while ago, did you mean to say this fixes Document GPOTrigger #286?
  2. There is an open PR to fix Broken link in api/overview.md #280 (Fix broken link to InterPulseInterval property #283)
  3. It looks like the submodule might not be pointing to the correct commit, the build failed saying the workflow has unknown types
  1. yea, fixed
  2. oh oops. I merged that PR into issue-272 and rebased this PR on issue-272.
  3. Thanks for noting that. To run it on my hardware (hs64 0.4), I merged issue-502-2 into main in the bonsai-onix1 repo. I recommend doing this to test this branch.

bparks13
bparks13 reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good! I've got a few more comments, but once those are addressed I am ready to merge.

This was referenced Oct 31, 2025
Open
Open
@cjsha
bparks feedback, second pass
79d4782 
Also:
- Add dotnet xrefmap in docfx.json so I can use `<xref:System.Double>`.
- Remove include for now, the long-term solution will be to add a template.
- Remove `Condition` operator from Headstage64GpoTrigger branch
  This node's unnecessary bc only True values trigger stimulus anyway.
@cjsha
Copy link
Member Author

cjsha commented Nov 3, 2025

Note to self: make sure the stimuli waveforms have reasonable parameters.

@cjsha
Copy link
Member Author

cjsha commented Nov 3, 2025 •
edited
Loading

Note to self: make sure there is note about 0.7.0 doesn't support hs 64 firmware version <0.4

bparks13
bparks13 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes! I see some other comments, so I won't merge this, but feel free to merge it if we want to address the comments in other PRs

jonnew
jonnew requested changes Nov 4, 2025
View reviewed changes
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnew jonnew jonnew requested changes

@bparks13 bparks13 bparks13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document e-stim and o-stim reports from hs64 Document GPOTrigger

4 participants

@cjsha @bparks13 @jonnew