Switch from datalogic-rs v4 to v3 #14
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrades datalogic-rs dependency from version 4 to version 3 per project requirements.
Changes
Cargo.toml:
datalogic-rs = "4.0"→"3.0"(resolves to v3.1.1)Custom operator trait migration: All operators (
FractionalOperator,StartsWithOperator,EndsWithOperator,SemVerOperator) migrated from v4'sOperatortrait to v3'sCustomOperatortrait with arena-based allocationadd_operator()→register_custom_operator()&'a DataValue<'a>via arena instead of ownedValueContextStack,Error,Evaluator→CustomOperator,DataArena,EvalContext,LogicErrorEvaluation calls:
evaluate_json(str, str)→evaluate_str(str, str)due to v3 signature changesAPI Example
Before (v4):
After (v3):
Behavior Change
Missing variables now return
nullper JSON Logic spec (v3 behavior) rather than throwing errors (v4 behavior). Updatedtest_eval_fractional_missing_varto reflect spec-compliant behavior.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.