chore: Updated dependencies and corrected checkstyle violations #1259
Conversation
|
justinabrahms
changed the title
| <groupId>com.puppycrawl.tools</groupId> | ||
| <artifactId>checkstyle</artifactId> | ||
| <version>8.45.1</version> | ||
| <version>10.21.0</version> |
There was a problem hiding this comment.
Our build is running on java 8, check style 10+ require Java 11 - I think this will not work
There was a problem hiding this comment.
Mockito and check style in this pull request version require Java 11 - we are building with Java 8. Hence this will not work.
As target version 1.8 is a requirement, we can think of updating our test build to a newer version, where we are executing those targets, but we are not able to merge this as is
|
with the migration to java 17 as our build java, all of this issues have been resolved and we have updated everything to the newest version, which are now updated via renovate accordingly. Thank you for the pull request and your efforts |
3 participants
Dependency Dashboard
Related Issues
Fixes #89
Notes
"<p>"tag. I have just modified those lines.How to test