-
Notifications
You must be signed in to change notification settings - Fork 91
feat: added-flagsmith-php-provider #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zaimwa9
wants to merge
12
commits into
open-feature:main
Choose a base branch
from
Zaimwa9:feat/add-flagsmith-php-to-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fa58030
feat: added-flagsmith-php-provider
Zaimwa9 f97c6db
chore: update sdk readmes (#1314)
openfeaturebot 1dce77f
feat: add-rust-provider-documentation (#1321)
Zaimwa9 bd2d045
feat: added-flagsmith-ruby-provider (#1318)
Zaimwa9 64b2567
chore: update sdk readmes (#1320)
openfeaturebot ef7ee8a
chore(deps): update external-content/community digest to 53bce15 (#1322)
renovate[bot] 3c9c833
chore: update sdk readmes (#1324)
openfeaturebot d0d720f
chore: update sdk readmes (#1325)
openfeaturebot 1dc21e0
feat: added-link-to-php-provider
Zaimwa9 c5cb616
Merge branch 'main' into feat/add-flagsmith-php-to-list
Zaimwa9 9082133
feat: reordered-alphabetically
Zaimwa9 589ff43
Merge branch 'feat/add-flagsmith-php-to-list' of github.com:Zaimwa9/o…
Zaimwa9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm that the provider can be installed? I think there may have been an issue pushing to the open-feature-php org. I pinged @tcarrio to see if he could help me with the troubleshooting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course. I'll take a look and keep you posted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beeme1mr @tcarrio
My understanding after going through the workflows is that we would need to create an empty repo in the open-feature-php org and re-run the split workflow with the open-feature/flagsmith-provider-0.1.1, is it right?
It seems the workflow failed because the target repo does not exist. I am not sure whether we need to configure packagist to pick it up.
Let me know how can I assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcarrio is going to look into this when he has a moment. It's a bit complex because it's difficult to publish PHP packages from a monorepo. Sorry for the delay on this.