Fix Clickhouse IPv4/IPv6 address serialization in sample data ingestion #25077
+205
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Clickhouse ingestion fails when tables contain IPv4 or IPv6 columns. The
clickhouse-sqlalchemydriver returns Pythonipaddress.IPv4Addressandipaddress.IPv6Addressobjects which cannot be JSON-serialized by Pydantic, causing the error:Changes:
ingest_table_sample_data()intable_mixin.pyto convert IP address objects to strings before serializationImplementation:
This follows the existing pattern for handling
bytestypes and extends support to IP address objects returned by Clickhouse.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by Gitar
ipaddress.IPv4Addressandipaddress.IPv6Addresstypes intable_mixin.py:94-97test_table_mixin.pywith 5 unit tests covering IPv4, IPv6, mixed types, None values, and error handlingThis will update automatically on new commits.