Skip to content

Conversation

@IceS2
Copy link
Contributor

@IceS2 IceS2 commented Jan 7, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Configuration update:
    • Changed Data Insights retention from 7 to 90 days across schema definitions and application configs
  • Schema files modified:
    • Updated dataInsightsAppConfig.json default value, DataInsightsApplication.json runtime configs, and marketplace definition
  • Frontend synchronization:
    • Updated ApplicationSchemas/DataInsightsApplication.json to reflect new 90-day retention default in UI forms

This will update automatically on new commits.


@IceS2 IceS2 changed the title Update Data Insights Retention to 30 days Update Data Insights Retention to 90 days Jan 7, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 7, 2026

Note: The PR title mentions "90 days" but the actual code changes update the retention from 7 to 30 days. You may want to update the title to match the implementation.

Details

All four configuration files show the retention value being changed to 30:

  • dataInsightsAppConfig.json: "default": 30
  • DataInsightsApplication.json: "retention": 30
  • Marketplace definition: "retention": 30
  • Frontend schema: "default": 30

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.37% (52820/80802) 43.4% (26308/60620) 46.82% (8221/17560)

@gitar-bot
Copy link

gitar-bot bot commented Jan 10, 2026

🔍 CI failure analysis for b0844eb: Five CI failures: Python network timeout, two Playwright flaky tests, and two Maven jobs with disk space exhaustion on same runner - all infrastructure/flakiness issues unrelated to config changes.

Issue

Five CI jobs failed from this workflow run:

1. py-run-tests (3.11) - Job 59994395348 - Network timeout
2. playwright-ci-postgresql (3, 6) - Job 59994395283 - 1 flaky test
3. playwright-ci-postgresql (5, 6) - Job 59994395274 - 1 flaky test
4. maven-postgresql-ci - Job 59994395239 - Disk space exhaustion
5. maven-sonarcloud-ci - Job 59994395293 - Disk space exhaustion

Root Causes

1. Python 3.11 - Network Timeout

Exit code 28 downloading IBM ODBC driver during Docker build.

2-3. Playwright Shards - Flaky Tests

Shard 3/6: Metric Entity test - element attachment timing
Shard 5/6: Data Steward test - element visibility timing

4-5. Maven Jobs - Disk Space Exhaustion (Same Runner)

Both maven-postgresql-ci and maven-sonarcloud-ci failed with identical error:

System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20260110-143315-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.StreamWriter.Flush(Boolean flushStream)

Infrastructure failure: GitHub Actions shared runner ran out of disk space

Characteristics:

  • maven-postgresql-ci: Ran for ~2h 51min (14:33:15 - 17:24:00 UTC)
  • maven-sonarcloud-ci: Ran for ~3h 33min (14:33:15 - 18:06:04 UTC)
  • Both jobs on same runner instance: Worker_20260110-143315-utc
  • Failed while writing diagnostic logs (disk completely full)
  • No test failures or compilation errors before disk exhaustion
  • Runner accumulated build artifacts over ~3+ hours

Analysis: Both Maven jobs started simultaneously at 14:33:15 UTC on the same shared runner. As they built and tested over 3+ hours, the runner's disk filled up. maven-postgresql-ci failed first after ~2h 51min, then maven-sonarcloud-ci failed 42 minutes later after ~3h 33min.

Details

Summary by failure type:

  1. Python (1 job) - Infrastructure: network timeout to external server
  2. Playwright shard 3/6 (1 job) - Flaky E2E: element timing
  3. Playwright shard 5/6 (1 job) - Flaky E2E: element timing
  4. Maven PostgreSQL (1 job) - Infrastructure: disk space on shared runner
  5. Maven SonarCloud (1 job) - Infrastructure: disk space on same shared runner

Unrelated to this PR's changes: This PR only modifies Data Insights retention configuration (7→90 days). All five failures are caused by:

  • External infrastructure (IBM download timeout, disk space)
  • E2E test flakiness (timing-dependent UI assertions)
Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Clean configuration update changing Data Insights retention from 7 to 90 days across all relevant JSON files. Changes are consistent and well-coordinated.

Suggestions 💡 1 suggestion
Code Quality: Unrelated .gitignore change bundled with retention update

📄 .gitignore:9

The addition of _bmad/ to .gitignore appears unrelated to the Data Insights retention configuration update. This mixes unrelated changes in a single PR.

Impact: Makes the PR harder to review and understand, and can complicate git history and potential reverts.

Suggested fix: Consider separating this into its own commit or PR, or at minimum document why this change is included in the PR description.

Resolved ✅ 1 resolved
Code Quality: PR title says "90 days" but code changes to 30 days

📄 openmetadata-service/src/main/resources/json/data/app/DataInsightsApplication.json:21 📄 openmetadata-spec/src/main/resources/json/schema/entity/applications/configuration/internal/dataInsightsAppConfig.json:61
The PR title states "Update Data Insights Retention to 90 days" but the actual code changes update the retention value from 7 to 30 days across all configuration files.

This discrepancy could cause confusion during review, merge, and for anyone later reading the git history to understand what retention value was intended.

Suggested fix: Either:

  1. Update the PR title to "Update Data Insights Retention to 30 days" if 30 is the intended value, or
  2. Change the retention values in the code from 30 to 90 if 90 days is actually the desired retention period.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants