-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Data Insights Retention to 90 days #25111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note: The PR title mentions "90 days" but the actual code changes update the retention from 7 to 30 days. You may want to update the title to match the implementation. DetailsAll four configuration files show the retention value being changed to
|
🔍 CI failure analysis for b0844eb: Five CI failures: Python network timeout, two Playwright flaky tests, and two Maven jobs with disk space exhaustion on same runner - all infrastructure/flakiness issues unrelated to config changes.IssueFive CI jobs failed from this workflow run: 1. py-run-tests (3.11) - Job 59994395348 - Network timeout Root Causes1. Python 3.11 - Network TimeoutExit code 28 downloading IBM ODBC driver during Docker build. 2-3. Playwright Shards - Flaky TestsShard 3/6: Metric Entity test - element attachment timing 4-5. Maven Jobs - Disk Space Exhaustion (Same Runner)Both maven-postgresql-ci and maven-sonarcloud-ci failed with identical error: Infrastructure failure: GitHub Actions shared runner ran out of disk space Characteristics:
Analysis: Both Maven jobs started simultaneously at 14:33:15 UTC on the same shared runner. As they built and tested over 3+ hours, the runner's disk filled up. maven-postgresql-ci failed first after ~2h 51min, then maven-sonarcloud-ci failed 42 minutes later after ~3h 33min. DetailsSummary by failure type:
Unrelated to this PR's changes: This PR only modifies Data Insights retention configuration (7→90 days). All five failures are caused by:
Code Review 👍 Approved with suggestions 1 resolved / 2 findingsClean configuration update changing Data Insights retention from 7 to 90 days across all relevant JSON files. Changes are consistent and well-coordinated. Suggestions 💡 1 suggestionCode Quality: Unrelated .gitignore change bundled with retention updateThe addition of Impact: Makes the PR harder to review and understand, and can complicate git history and potential reverts. Suggested fix: Consider separating this into its own commit or PR, or at minimum document why this change is included in the PR description. Resolved ✅ 1 resolvedCode Quality: PR title says "90 days" but code changes to 30 days
Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
|



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
7to90days across schema definitions and application configsdataInsightsAppConfig.jsondefault value,DataInsightsApplication.jsonruntime configs, and marketplace definitionApplicationSchemas/DataInsightsApplication.jsonto reflect new 90-day retention default in UI formsThis will update automatically on new commits.