Skip to content

Conversation

@aji-aju
Copy link
Contributor

@aji-aju aji-aju commented Jan 8, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Schema deprecation:
    • Marked authorityUrl as deprecated in samlSSOClientConfig.json with entityId as replacement
  • UI field hiding:
    • Hidden authorityUrl from SAML configuration form in SSO.constant.ts using RJSF ui:widget: hidden
  • Backward compatibility:
    • Field remains optional and accepted by backend to support existing configurations

This will update automatically on new commits.


chirag-madlani
chirag-madlani previously approved these changes Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

TypeScript types have been updated based on the JSON schema changes in the PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.25% (52209/80016) 43.14% (25828/59875) 46.53% (8094/17394)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@gitar-bot
Copy link

gitar-bot bot commented Jan 9, 2026

🔍 CI failure analysis for 3c41876: Five CI failure types: Python type checking (from main), Playwright flaky tests, two Maven jobs with disk space exhaustion; all unrelated to SAML changes.

Issues

Five types of CI failures on this PR (post-merge from main):

  1. Python type checking (py-run-tests 3.10, 3.11): Multiple jobs - same error
  2. Playwright tests (3, 6): Flaky test failures
  3. maven-postgresql-ci (Job 59875770017): Disk space exhaustion
  4. maven-sonarcloud-ci (Job 59875770010): Disk space exhaustion (NEW)
  5. Previous runs: Similar infrastructure issues documented

Root Causes

1. Python Type Checking (Multiple Jobs)

Error: builder_end_to_end.py:254:15 - error: Argument missing for parameter "extension"

From main branch merge (commit 3c41876), not this PR.

2. Playwright Flaky Tests

Results: 3 failed, 9 flaky, 454 passed - typical flaky test pattern.

3-4. Maven Jobs - Infrastructure Disk Space Exhaustion

Both maven-postgresql-ci and maven-sonarcloud-ci failed with identical error:

System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20260109-042602-utc.log'

GitHub Actions runners ran out of disk space. This is a recurring infrastructure problem affecting multiple Maven jobs in this CI run.

Details

PR Changes (SAML deprecation):

  • Deprecated authorityUrl field in SAML schema with deprecated: true
  • Hidden authorityUrl from SAML UI form using RJSF ui:widget: hidden
  • Auto-generated TypeScript type updates
  • Zero Python code changes
  • Zero Java/Maven code changes

Why all failures are unrelated to this PR:

  1. Python failures: Type checking error in file not modified by this PR (from main branch merge)
  2. Playwright failures: Flaky tests in unrelated functional areas
  3. Maven disk space failures: Infrastructure issue with GitHub Actions runners - cannot be caused by minimal schema deprecation changes

Assessment

All CI failures are infrastructure issues or pre-existing problems:

  • Python: Fix builder_end_to_end.py:254 to include extension parameter (issue from main branch)
  • Playwright: Typical flaky tests, unrelated to SAML configuration
  • Maven: Persistent GitHub Actions disk space problem affecting multiple jobs on the same runner/timestamp

None of these failures are caused by the SAML authorityUrl deprecation changes in this PR, which only modified JSON schema and TypeScript/UI files.

Failure Types: Infrastructure (disk space) + Build (type checking from main) + Flaky tests

Code Review ✅ Approved

Clean deprecation of SAML authorityUrl field in favor of entityId. The schema properly marks it deprecated while the UI hides it, maintaining backward compatibility.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@chirag-madlani chirag-madlani merged commit 9eeb2c7 into main Jan 9, 2026
30 of 37 checks passed
@chirag-madlani chirag-madlani deleted the saml_authorityurl_hide branch January 9, 2026 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Changes have been cherry-picked to the 1.11.5 branch.

github-actions bot added a commit that referenced this pull request Jan 9, 2026
* Deprecated saml authority url, hided from UI

* Update generated TypeScript types

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 9eeb2c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants