Skip to content

[Fix] Fix testing without labels features#3649

Open
bjzhb666 wants to merge 1 commit intoopen-mmlab:mainfrom
bjzhb666:bjzhb666/test_without_visualization_labels
Open

[Fix] Fix testing without labels features#3649
bjzhb666 wants to merge 1 commit intoopen-mmlab:mainfrom
bjzhb666:bjzhb666/test_without_visualization_labels

Conversation

@bjzhb666
Copy link
Copy Markdown

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Now, testing with labels is the default setting, which is not common.

Modification

Change the default value from True to False

BC-breaking (Optional)

NO.

Use cases (Optional)

No need.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@MGAMZ MGAMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a better solution to modify this param in config, rather than directly modify default values globally, considering most datasets have named labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants