Make mmseg to be able to run on mmcv=2.2.0#3663
Open
rabinadk1 wants to merge 3 commits intoopen-mmlab:mainfrom
Open
Make mmseg to be able to run on mmcv=2.2.0#3663rabinadk1 wants to merge 3 commits intoopen-mmlab:mainfrom
rabinadk1 wants to merge 3 commits intoopen-mmlab:mainfrom
Conversation
1. Documentation says it is okay to run with mmcv >= 2.2.0 but mmseg incorrectly asserts. 2. Provide better error messages to pinpoint if the versions are higher or lower
MGAMZ
suggested changes
May 31, 2024
mmseg/__init__.py
Outdated
|
|
||
| MMCV_MIN = '2.0.0rc4' | ||
| MMCV_MAX = '2.2.0' | ||
| MMCV_MAX = '2.3.0' |
Contributor
There was a problem hiding this comment.
Directly changing the support version may be dangerous
|
can we get this merged? |
Contributor
I believe it's OK, but I am just a contributor without merge permission. This project has been paused for several months. ----From a dissappointed contributor......... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The documentation says it is okay to run with
mmcv >= 2.2.0, butmmsegincorrectly asserts it to be less than 2.2.0.Modification
mmcvwith version 2.2.0 to run with the latestmmsegpackage.BC-breaking (Optional)
No
Use cases (Optional)
N/A
Checklist