Fixed issue with backward docking and added initial in-place rotation#70
Open
Jakubach wants to merge 4 commits intoopen-navigation:humblefrom
Open
Fixed issue with backward docking and added initial in-place rotation#70Jakubach wants to merge 4 commits intoopen-navigation:humblefrom
Jakubach wants to merge 4 commits intoopen-navigation:humblefrom
Conversation
SteveMacenski
requested changes
Nov 13, 2024
Member
There was a problem hiding this comment.
See ros-navigation/navigation2#4749 (review)
If it helps, maybe we just do reviews in the navigation2 version so we get it all hammered out there. Then once that is approved, we update this PR. I think that'll make your life easier than repeatedly doing the same thing 2x each review cycle. I could see that getting frustrating :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: