-
Notifications
You must be signed in to change notification settings - Fork 12
Allow passing existing connect app #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing existing connect app #862
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 96.36% 98.96% +2.59%
==========================================
Files 7 9 +2
Lines 220 289 +69
Branches 30 43 +13
==========================================
+ Hits 212 286 +74
+ Misses 7 3 -4
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3939fa5 to
997290e
Compare
zcstarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good just the few comments here to tidy it up
Co-authored-by: Zane Starr <zcstarr@gmail.com>
Co-authored-by: Zane Starr <zcstarr@gmail.com>
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
appoption in READMEserver.stop()stopandstartare asyncTesting
npm testfixes #774
fixes #759