Skip to content

Conversation

@shanejonas
Copy link
Member

@shanejonas shanejonas commented May 26, 2025

Summary

  • allow HTTP and HTTPS transports to accept a preexisting connect/express app
  • document app option in README
  • test using an external app
  • adds server.stop()
  • ensure stop and start are async

Testing

  • npm test

fixes #774
fixes #759

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (f772779) to head (d7818ac).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   96.36%   98.96%   +2.59%     
==========================================
  Files           7        9       +2     
  Lines         220      289      +69     
  Branches       30       43      +13     
==========================================
+ Hits          212      286      +74     
+ Misses          7        3       -4     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanejonas shanejonas removed the codex label May 26, 2025
@shanejonas shanejonas force-pushed the feat/allow-passing-express-app-for-integration branch from 3939fa5 to 997290e Compare May 27, 2025 00:44
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good just the few comments here to tidy it up

shanejonas and others added 4 commits May 28, 2025 19:14
@shanejonas shanejonas closed this May 29, 2025
@shanejonas shanejonas reopened this May 29, 2025
@shanejonas shanejonas merged commit 4c7b8a3 into master May 29, 2025
5 checks passed
@BelfordZ
Copy link
Member

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add server.stop() expose connect app from http transport

4 participants