-
Notifications
You must be signed in to change notification settings - Fork 0
Specify W modifier behavior for non-existing days and add LW combination in OCPS 1.3 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
5
commits into
main
Choose a base branch
from
copilot/improve-cron-w-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate handling of non-existing days with cron W
Specify W modifier behavior for non-existing days in OCPS 1.3
Nov 15, 2025
Copilot finished work on behalf of
Hexagon
November 15, 2025 19:03
Member
|
@copilot Keep the new additions lean, just focus on the key additions |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Author
Copilot finished work on behalf of
Hexagon
November 15, 2025 19:50
Member
|
@copilot Better, but make it just a bit more expressive, and leave the rationale/references to existing implementations out. |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Author
Copilot finished work on behalf of
Hexagon
November 15, 2025 19:53
Member
|
@copilot As 31W would just skip on months without 31 days, add the combination case LW which should resolve to the last weekday of the month in a smart way. Keep it lean. |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Author
Copilot
AI
changed the title
Specify W modifier behavior for non-existing days in OCPS 1.3
Specify W modifier behavior for non-existing days and add LW combination in OCPS 1.3
Nov 17, 2025
Copilot finished work on behalf of
Hexagon
November 17, 2025 21:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify W modifier behavior for non-existing days and add LW combination in OCPS 1.3
The OCPS 1.3 draft lacked specification for how
W(closest weekday) should handle non-existing days like31Win February.Changes:
LWcombination that resolves to the last weekday of the month, providing a smart solution for scheduling on the last business day of every month regardless of month lengthOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.