-
Notifications
You must be signed in to change notification settings - Fork 0
Clarify step notation syntax requirements in OCPS 1.0 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
|
@copilot bump the revision in 1.0 |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
|
I'll leave this open for discussion for a couple of weeks |
|
@copilot the change in "invalid step syntax"-section should be enough, tone down the other two changes |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
|
@copilot clarify if a single value as starting point (such as 10/10) should be allowed in addition of wildcard and range |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Clarified that single-value step notation like |
|
@copilot clarify if 0/15 should be allowed in addition to */15 while keeping the Vixie/cronie baseline intact |
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Analyzed Vixie cron source code (entry.c). The parser returns immediately after processing a single number not followed by |
|
@copilot Cronie does actually seem to allow a single number in A for A/B, from the crontab manpage: Investigate https://github.com/cronie-crond/cronie and allow |
... Investigated cronie source code (src/entry.c, master branch). The parser's R_NUM1 state only checks for The cronie man page mentions Tested paths through state machine:
Conclusion: Current spec is correct. Both Vixie and cronie implementations reject Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Plan: Clarify Step Notation Syntax in OCPS 1.0
Based on research into pre-existing implementations:
Findings:
/30- requires*/30orrange/step/30alone/30(treats as0/30)*/N) and proper ranges (10-16/2), no single-value step notation like10/10-), so it never checks for/step. This means single-value step notation like0/15is NOT supported in Vixie cron.Conclusion:
OCPS 1.0 explicitly disallows invalid step notation syntax to maintain strict Vixie cron compatibility:
/30syntax (step without preceding wildcard or range) is invalid0/15syntax (single value before step) is invalid - Vixie treats0as a single value and ignores/1510/10syntax (single value is not a proper rangeA-B) is invalidValid forms:
*/30(wildcard + step) or10-50/10(range with both endpoints + step)Changes Made:
/30,0/15, and10/10patterns/character MUST be preceded by either*or a range in the formA-Bwhere both A and B are specifiedTasks:
*or a range/30) to error handling section10/10) is also invalid0/15single-value step notation is also invalid per Vixie source code analysisOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.