-
-
Notifications
You must be signed in to change notification settings - Fork 176
Feature: savebutton #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cyhap01
wants to merge
82
commits into
open-source-labs:dev
Choose a base branch
from
oslabs-beta:feature/savebutton
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: savebutton #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
> > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
-Added svelvet-file-tree and scirpt.txt to gitignore -Titled README to reflect my branch -In Graph.svelte: Added comments to explain the file, added a Radio Group to the canvas for testing purposes. Note that the testing group does not work functionally. Found the 'quick save' feature started by previous devs, planning to define a function to save the canvas state as a JSON object in local storage -Added comments to +page.svelte to explain the file -Corrected typos in color-picker/test.ts comment Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
…ust the keyboard > > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
…ust the keyboard > > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
Mayson/canvaskeyboard func
Added type assertions in reloadStore.ts and saveStore.ts, getting rid of errors in functions. Added a test button to the +page.svelte svelvet wrapper to trigger the getJSONState function. Currently saves an empty object in local storage. Other comments added Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com> Co-authored-by: Julianb12 <Julianb12@users.noreply.github.com>
…oard shortcut 'd' to toggle drawer component > > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
…ts to the dev canvas > > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
… test. Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com>
> > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
- added a control flow to make sure transforms.scale property on Graph object exists as a number / reloadStore.ts - added a variable, graph, to subscribe to the graphStore and pass into getJSONState function / +page.svelte - added console logs to monitor graph state from mount to local storage Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
…ditor on a node using the 'e' key. > > Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
Toggle controls with 'c' key and render editor node with 'e' key Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Issac Bocage <ibocage1@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
Isaac feature branch
Mayson/keyboard functionality
Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Isaac Bocage ibocage1@gmail.com
Added ContrastTheme component Added a new component called ContrastTheme which allows different high contrast themes for visual accessibility Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Issac Bocage <ibocage1@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
Added 7 new high contrast themes Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Issac Bocage <ibocage1@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com> Co-authored-by: Julianb12 <Julianb12@users.noreply.github.com>
Develop traverse function to unravel nodes object and return array of nodes Add save button to theme toggle component Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
2/6/24 Add Save Button and Develop Traverse Function
Co-authored-by: Julianb12 <Julianb12@users.noreply.github.com>
Mayson / High-Contrast Theme Component
Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
the documentation Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Isaac Bocage <ibocage1@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
Contrast Theme Documentation
…lian Bos <julianb1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
…lian Bos <julianb1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
Solomon/readme
Pull Request for Main from Dev
…le.Co-authored-by: Julian Bos <julianb1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
…and themetoggle.Co-authored-by: Julian Bos <julianb1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
Svelvet v10.0 Pull Request
Co-authored-by: Julian Bos <julianb1212@gmail.com> Co-authored-by: Mayson Lee <mayson0717@gmail.com> Co-authored-by: Solomon Moon <chochobo91@gmail.com>
…m>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
…1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
pre-launch last minute changes
…es to package.jsonCo-authored-by: Julian Bos <julianb1212@gmail.com>Co-authored-by: Mayson Lee <mayson0717@gmail.com>Co-authored-by: Isaac Bocage <ibocage1@gmail.com>
Minor fixes to README and package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue-No linked issue attached.
Description
Checklist
I've followed the Contributing guidelines
I've titled my PR according to the Conventional Commits spec
I've linked an open issue
I've added tests that fail without this PR but pass with it
I've linted and tested my code
I've updated documentation (if appropriate)