-
Couldn't load subscription status.
- Fork 1k
Allow excluding Logback MDC attributes from being copied #14926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow excluding Logback MDC attributes from being copied #14926
Conversation
This change adds a setting to the Logback appender to exclude MDC attributes when all attributes are being copied.
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@trask additional context: I use Micrometer for tracing which adds the MDC values |
|
@cfredri4 if your intention is to get this merged then you firstly need to fix the compilation errors in your PR. Secondly you'll have to add tests. Ideally this functionality should be present for both the library and javaagent instrumentation in all relevant logging instrumentations. |
|
This PR has been labeled as stale due to lack of activity and needing author feedback. It will be automatically closed if there is no further activity over the next 7 days. |
|
@laurit I'll take a look at the other logging instrumentations, and tests.
Can you elaborate on what this means specifically? |
Besides logback library instrumentation (by library instrumentation we mean standalone instrumetnation that can be used without the agent) capturing mdc attributes is also implemented in the logback javaagent instrumentation (uses the library instrumentation, but is configured differently), log4j 1&2 and jboss logmanager. Search for |
Closes #14925